Skip to content
This repository was archived by the owner on Mar 17, 2024. It is now read-only.

Exclude enum types #287

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Exclude enum types #287

merged 2 commits into from
Apr 13, 2021

Conversation

@nagasawaryoya
Copy link
Contributor

@nagasawaryoya nagasawaryoya commented Apr 12, 2021

What was a problem

  • Using enum types creates opacity of behavior during transpiling.

How this PR fixes the problem

  • Replace enum type with const assertion.

Check lists (check x in [ ] of list items)

  • Test passed
  • Coding style (indentation, etc)

Additional Comments (if any)

fix #285

@kamiazya kamiazya self-assigned this Apr 13, 2021
@kamiazya kamiazya merged commit e9759d6 into ts-graphviz:master Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kamiazya kamiazya kamiazya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kamiazya kamiazya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exclude enum types

2 participants

@nagasawaryoya @kamiazya