Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay onboarding installation #162

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Delay onboarding installation #162

merged 6 commits into from
Nov 14, 2024

Conversation

jpan8866
Copy link

@jpan8866 jpan8866 commented Nov 14, 2024

Description ✏️

  • all installations happen (if selected) once welcome overlay is closed
  • no longer need to reload to go to inventory after welcome overlay

Checklist ✅

  • I have added screenshots (if UI changes are present).
  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).

@jpan8866 jpan8866 changed the title WIP Delay onboarding installation Delay onboarding installation Nov 14, 2024
Comment on lines +165 to +169
this.onWebview("pearAIinstallation", (msg) => {
const { tools, installExtensions } = msg.data;
if (installExtensions) {
vscode.commands.executeCommand("pearai.welcome.importUserSettingsFromVSCode");
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its importing extensions in pearAIinstallation. naming can be improved here. but its not a big deal.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very true

Copy link

@Himanshu-Singh-Chauhan Himanshu-Singh-Chauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nang-dev nang-dev merged commit dcdff4c into main Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants