Fix Computer Server/Lume version compatibility (Issue #544) #550
+197
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds protocol version compatibility checking between Computer SDK and Computer Server to prevent integration failures when Computer Server is updated in VM images.
Problem
When Computer Server is updated and VM images are rebuilt with new versions, there was no version checking between the Computer SDK (client) and Computer Server (running in VMs). This caused silent failures or confusing errors when
protocol versions didn't match (Issue #544).
Solution
GenericComputerInterface.wait_for_ready()Changes
Modified:
libs/python/computer/computer/interface/generic.pyEXPECTED_PROTOCOL_VERSION = 1constantversioncommand on connection and validates protocol versionComputer Server version: {package} (protocol: {version})Added:
libs/python/computer/tests/test_version_compatibility.pyBackward Compatibility
Old Computer Server instances without version info will log a warning but continue to work, ensuring backward compatibility.
Testing
Fixes #544