feat(lume): Add option to specify custom config file path#1082
feat(lume): Add option to specify custom config file path#1082marksisson wants to merge 1 commit intotrycua:mainfrom
Conversation
marksisson
commented
Feb 12, 2026
- Added --config CLI option to allow users to specify custom config file location
- SettingsManager now supports custom config file paths via setCustomConfigPath()
- Custom config path overrides default XDG_CONFIG_HOME location
- Parent directories are created automatically for custom config paths
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
@marksisson is attempting to deploy a commit to the Cua Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR adds a --config CLI option to allow specifying a custom configuration file path, and updates SettingsManager to read/write settings from that custom path instead of the default XDG-based location.
Changes:
- Added
--configoption to the rootlumecommand. - Added support in
SettingsManagerfor a custom config file path and custom parent directory creation. - Added pre-parse argument scanning to apply the custom config path before command parsing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| libs/lume/src/Main.swift | Adds --config option and early argument scanning to set the config path before parsing. |
| libs/lume/src/FileSystem/Settings.swift | Adds a custom config path override and adjusts directory creation behavior for saving settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Motivation for pull request: This provides a mechanism for configuration of Lume without relying on global state of the system, such as environment variables, file system layouts, or implicit paths. This is very helpful when building "wrappers" that want to invoke lume with a specific configuration, so that is does not rely on global state, e.g. I use nix, and this enables scenarios such as running directly from a remote flake without installing. |
944f2b0 to
26dedbf
Compare
5faf847 to
2c1fd20
Compare
150a8d2 to
e0abdaf
Compare
- Added --config CLI option to allow users to specify custom config file location - SettingsManager now supports custom config file paths via setCustomConfigPath() - Custom config path overrides default XDG_CONFIG_HOME location - Parent directories are created automatically for custom config paths