Skip to content

feat: add optional VNC password authentication#1072

Open
r33drichards wants to merge 3 commits intomainfrom
feat/vnc-password-auth
Open

feat: add optional VNC password authentication#1072
r33drichards wants to merge 3 commits intomainfrom
feat/vnc-password-auth

Conversation

@r33drichards
Copy link
Collaborator

@r33drichards r33drichards commented Feb 10, 2026

Summary

  • Adds optional VNC password authentication to the XFCE container via VNC_PW environment variable
  • When VNC_PW is set, the VNC server uses VncAuth with a password file; otherwise, it runs without authentication (preserving existing behavior)
  • Password file is created with restricted permissions (600) for security

Test plan

  • Verify container starts without VNC_PW set (no-auth mode, existing behavior)
  • Verify container starts with VNC_PW=somepassword and requires password to connect
  • Verify VNC client can connect with correct password
  • Verify VNC client is rejected with incorrect password

🤖 Generated with Claude Code

r33drichards and others added 2 commits February 10, 2026 11:30
@r33drichards @claude
fix: remove message filtering that was causing variable reference error
75543f6 
Removed filterEmptyMessages call and use messages directly. This fixes
the build error where filteredMessages was undefined after previous
partial changes.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@r33drichards @claude
feat: add optional VNC password authentication via VNC_PW env var
e33e585 
When VNC_PW is set, VNC server uses password authentication instead of
running with no security. This allows securing VNC connections in
environments where the server is exposed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link
Contributor

vercel bot commented Feb 10, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Feb 10, 2026 8:00pm

Request Review

@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • rabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/vnc-password-auth

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

📦 Publishable packages changed

  • docker/xfce

Add release:<service> labels to auto-release on merge (+ optional bump:minor or bump:major, default is patch).
Or add no-release to skip.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

📦 Publishable packages changed

  • docker/xfce

Add release:<service> labels to auto-release on merge (+ optional bump:minor or bump:major, default is patch).
Or add no-release to skip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddupont808 ddupont808 ddupont808 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r33drichards @ddupont808