[dev] [Marfuen] mariano/make-portal-great-again #1945
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryIntroduces a new Chakra UI design system package (@trycompai/ui-new) and integrates it into the portal with provider setup, config updates, and demo pages.
Written by Cursor Bugbot for commit 4b45872. This will update automatically on new commits. Configure here. |
Graphite Automations"Auto-assign PRs to Author" took an action on this PR • (12/18/25)1 reviewer was added to this PR based on Mariano Fuentes's automation. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| busywork, win more deals and accelerate growth. | ||
| </p> | ||
| <Button variant="link" className="mt-2 p-0" asChild> | ||
| <Button variant="outline" className="mt-2 p-0" asChild> |
There was a problem hiding this comment.
Bug: Button variant incompatible with zero padding styling
The Button changed from variant="link" (old UI library) to variant="outline" with className="mt-2 p-0". An outline variant button has a visible border, and p-0 removes all padding, causing the text content to touch the border directly. This creates a visually broken appearance. The equivalent variant in the new Chakra-based library for link-styled buttons is variant="plain", which has no border and works correctly with zero padding.
| const [running, setRunning] = React.useState(true); | ||
| const toggle = () => setRunning(!running); | ||
| return <Box onClick={toggle}>{running ? <LuPause /> : <LuPlay />}</Box>; | ||
| }; |
There was a problem hiding this comment.
Bug: Carousel autoplay icon state disconnected from actual autoplay
The AutoplayIcon component maintains its own local running state that is completely disconnected from the actual carousel autoplay state. The icon defaults to running=true on mount regardless of whether the carousel is actually autoplaying. While clicking toggles both the local state and the actual autoplay (via Carousel.AutoplayTrigger), they can become out of sync if autoplay changes through other means, or if the carousel doesn't start with autoplay enabled. The component should use the carousel context to get the actual autoplay state instead of managing independent local state.
…te in UI components
| <LinkButton href={getHref(props.value)} variant={variant} size={size}> | ||
| {props.value} | ||
| </LinkButton> | ||
| ); |
There was a problem hiding this comment.
Bug: Pagination components ignore props and refs when using href
The PaginationItem, PaginationPrevTrigger, and PaginationNextTrigger components are declared with forwardRef and accept typed props, but when getHref is provided, neither the ref nor the remaining props are forwarded to the returned LinkButton. This creates inconsistent behavior where props like event handlers, className, or aria attributes work when using button-based pagination but are silently ignored when using link-based pagination with getHref.
This is an automated pull request to merge mariano/make-portal-great-again into dev.
It was created by the [Auto Pull Request] action.