Skip to content

Conversation

@Marfuen
Copy link
Contributor

@Marfuen Marfuen commented Dec 10, 2025

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes COMP-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel
Copy link

vercel bot commented Dec 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
app Building Building Preview Comment Dec 10, 2025 7:05pm
portal Building Building Preview Comment Dec 10, 2025 7:05pm

@cursor
Copy link

cursor bot commented Dec 10, 2025

PR Summary

Adds support for provider-specific additional OAuth settings that drive authorizeUrl token replacement and dynamic admin UI fields.

  • Backend/API
    • Expose additionalOAuthSettings in GET /v1/admin/integrations and GET /v1/admin/integrations/:providerSlug.
    • In OAuth start, replace authorizeUrl tokens using additionalOAuthSettings and provided customSettings.
  • Frontend/Admin UI
    • Add dynamic "Additional OAuth Settings" section on integration config form; validate required fields and include in customSettings when saving credentials.
  • Integration Manifests
    • rippling: define additionalOAuthSettings with appName mapped to {APP_NAME}.
    • vercel: switch to additionalOAuthSettings with appSlug mapped to {APP_SLUG}.
  • Types
    • Update OAuthConfig to include additionalOAuthSettings (replacing previous custom settings field).

Written by Cursor Bugbot for commit 5804fb1. This will update automatically on new commits. Configure here.

@Marfuen Marfuen merged commit e84e4b0 into main Dec 10, 2025
8 of 12 checks passed
@Marfuen Marfuen deleted the mariano/fix-13 branch December 10, 2025 19:06
[setting.id]: e.target.value,
})
}
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Input type attribute not passed for additional settings

The AdditionalOAuthSetting interface defines a type field ('text' | 'password' | 'textarea' | 'select' | 'combobox'), but the Input component rendering doesn't use setting.type. This means if a provider configures a setting with type: 'password', the input won't mask the value. Similarly, textarea, select, and combobox types are ignored and render as plain text inputs. The type attribute needs to be passed to the Input component or appropriate components selected based on the type.

Fix in Cursor Fix in Web

@graphite-app
Copy link

graphite-app bot commented Dec 10, 2025

Graphite Automations

"Auto-assign PRs to Author" took an action on this PR • (12/10/25)

1 assignee was added to this PR based on Mariano Fuentes's automation.

@claudfuen
Copy link
Contributor

🎉 This PR is included in version 1.70.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants