-
Notifications
You must be signed in to change notification settings - Fork 220
Mariano/fix 13 #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mariano/fix 13 #1900
Conversation
…and auto-check services
PR SummaryAdds support for provider-specific additional OAuth settings that drive authorizeUrl token replacement and dynamic admin UI fields.
Written by Cursor Bugbot for commit 5804fb1. This will update automatically on new commits. Configure here. |
| [setting.id]: e.target.value, | ||
| }) | ||
| } | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Input type attribute not passed for additional settings
The AdditionalOAuthSetting interface defines a type field ('text' | 'password' | 'textarea' | 'select' | 'combobox'), but the Input component rendering doesn't use setting.type. This means if a provider configures a setting with type: 'password', the input won't mask the value. Similarly, textarea, select, and combobox types are ignored and render as plain text inputs. The type attribute needs to be passed to the Input component or appropriate components selected based on the type.
Graphite Automations"Auto-assign PRs to Author" took an action on this PR • (12/10/25)1 assignee was added to this PR based on Mariano Fuentes's automation. |
|
🎉 This PR is included in version 1.70.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist