-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Mark params and operations as deprecated in src/libs/Cohere/openapi.yaml #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds deprecated: true flags in src/libs/Cohere/openapi.yaml for specific parameters and multiple path operations, including the parameter referencing Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (8)
src/libs/Cohere/openapi.yaml (8)
1128-1134
: Same placement check as above. Ensuredeprecated
is at the Operation level.Duplicate of the previous comment; please lint this block too.
1198-1204
: Same placement check as above.
1271-1277
: Same placement check as above.
1343-1349
: Same placement check as above.
1421-1427
: Same placement check as above.
1501-1507
: Same placement check as above.
6623-6629
: Same placement check as above.
7178-7184
: Same placement check as above.
🧹 Nitpick comments (2)
src/libs/Cohere/openapi.yaml (2)
63-69
: Clarify the deprecation scope and guidance for consumers.If the intent is to deprecate this request-body field (the array of
ChatConnector
items), schema-leveldeprecated: true
is fine. If instead the whole parameter is deprecated (e.g., a query/header param), placedeprecated: true
on the Parameter Object, not just its schema. Also, add explicit migration guidance (what to use instead) so SDKs and docs surface a clear path.Consider appending a short deprecation note to
description
(replacement and removal timeline). If helpful, I can draft consistent deprecation text across all affected fields.
168-174
: Provide migration path forsearch_queries_only
and confirm deprecation level.Schema-level
deprecated: true
marks the field as deprecated; confirm that this is the intended scope. Add replacement guidance indescription
(e.g., the new flag/endpoint to use) to avoid ambiguity in generated docs/SDKs.I can generate a one-liner deprecation blurb template if you share the replacement.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (21)
src/libs/Cohere/Generated/Cohere.CohereClient.Chat.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.CohereClient.Classify.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.CohereClient.Generate.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.CohereClient.Summarize.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ConnectorsClient.CreateConnector.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ConnectorsClient.DeleteConnector.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ConnectorsClient.GetConnector.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ConnectorsClient.ListConnectors.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ConnectorsClient.OAuthAuthorizeConnector.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ConnectorsClient.UpdateConnector.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ICohereClient.Chat.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ICohereClient.Classify.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ICohereClient.Generate.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ICohereClient.Summarize.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.IConnectorsClient.CreateConnector.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.IConnectorsClient.DeleteConnector.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.IConnectorsClient.GetConnector.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.IConnectorsClient.ListConnectors.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.IConnectorsClient.OAuthAuthorizeConnector.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.IConnectorsClient.UpdateConnector.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.ChatRequest.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Cohere/openapi.yaml
(11 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test / Build, test and publish
🔇 Additional comments (1)
src/libs/Cohere/openapi.yaml (1)
1004-1010
: No change needed —deprecated
is correctly attached to the Operation object.Verified in src/libs/Cohere/openapi.yaml (around lines 1002–1010):
deprecated: true
is a sibling ofresponses
(not nested under '503'/'504').
Summary by CodeRabbit
Documentation
Chores