Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest.json: Xóa version number của package voluptuous #55

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

duytung1009
Copy link
Contributor

Update manifest.json: Xóa version number của package voluptuous

Description

Phiên bản Home Assistant Core 2024.8 đã update voluptuous lên bản 0.15.2, nhưng add-on đang để version cố định voluptuous==0.13.1 dẫn đến lỗi trong quá trình setup. PR này xóa version number của package voluptuous để tránh xảy ra lỗi (theo mình hiểu thì nếu không chỉ định version number cho voluptuous thì sẽ tự load phiên bản hiện tại trên hass)

home-assistant/core#120631

hass_nestup_env_issue_2
hass_nestup_env_issue

Type of change

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test thủ công ở môi trường local

  • Black
  • Flake8
  • Isort

Test Configuration:

  • OS version: Home Assistant OS
  • HA version: Home Assistant Core 2024.8
  • HA platform:
  • Hardware: Generic x86

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Update manifest.json to fix an issue with Home Assistant Core 2024.8 release (Update voluptuous to 0.15.2)
@duytung1009 duytung1009 mentioned this pull request Aug 8, 2024
@trvqhuy trvqhuy merged commit f86bef7 into trvqhuy:main Aug 8, 2024
4 checks passed
@trvqhuy
Copy link
Owner

trvqhuy commented Aug 8, 2024

Cảm ơn bạn @duytung1009 vì đóng góp này, mình đã merge và release phiên bản sửa lỗi mới nhất.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants