Skip to content

Conversation

@satoshiotomakan
Copy link
Collaborator

This pull request introduces support for a new staking operation in the Polkadot blockchain: BondExtraAndNominate. It includes updates to the encoding logic, tests, and protocol definitions to handle this new operation.

Staking Operation Enhancements:

  • Added support for the BondExtraAndNominate operation in the Staking module, including its definition in src/proto/Polkadot.proto and integration into the CallEncoder logic. (rust/chains/tw_polkadot/src/call_encoder/mod.rs, src/proto/Polkadot.proto) [1] [2] [3] [4]

Testing Updates:

  • Introduced a new test case for the BondExtraAndNominate operation to validate encoding and signing functionality. (rust/tw_tests/tests/chains/polkadot/polkadot_compile.rs)
  • Enhanced error reporting in existing tests to include error messages for better debugging. (rust/tw_tests/tests/chains/polkadot/mod.rs) [1] [2]

Codebase Adjustments:

  • Updated imports and dependencies to accommodate the new staking operation and related utilities. (rust/tw_tests/tests/chains/polkadot/polkadot_compile.rs)

@satoshiotomakan satoshiotomakan requested a review from gupnik as a code owner June 20, 2025 06:39
@github-actions
Copy link

github-actions bot commented Jun 20, 2025

Binary size comparison

➡️ aarch64-apple-ios:

- 14.02 MB
+ 14.02 MB 	 +4 KB

➡️ aarch64-apple-ios-sim:

- 14.02 MB
+ 14.02 MB 	 +4 KB

➡️ aarch64-linux-android:

- 18.49 MB
+ 18.49 MB 	 +6 KB

➡️ armv7-linux-androideabi:

- 15.47 MB
+ 15.47 MB 	 +4 KB

➡️ wasm32-unknown-emscripten:

- 13.17 MB
+ 13.17 MB 	 +5 KB

Copy link
Collaborator

@gupnik gupnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@satoshiotomakan satoshiotomakan merged commit 385185d into master Jun 20, 2025
17 checks passed
@satoshiotomakan satoshiotomakan deleted the feat/polkadot-bond-extra-and-nominate branch June 20, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants