Skip to content

Conversation

@gupnik
Copy link
Collaborator

@gupnik gupnik commented May 29, 2025

Description

This PR adds the safety CI and fixes various memory leaks.

How to test

Run existing tests

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@gupnik gupnik requested a review from satoshiotomakan as a code owner May 29, 2025 11:06
@github-actions
Copy link

github-actions bot commented May 29, 2025

Binary size comparison

➡️ aarch64-apple-ios: 14.01 MB

➡️ aarch64-apple-ios-sim: 14.01 MB

➡️ aarch64-linux-android: 18.48 MB

➡️ armv7-linux-androideabi: 15.46 MB

➡️ wasm32-unknown-emscripten: 13.16 MB

@gupnik gupnik changed the title [WIP]: Adds Rust Memory Leak Checker Adds Rust Memory Leak Checker May 30, 2025
@gupnik gupnik changed the title Adds Rust Memory Leak Checker Adds Safety and Codecov CI May 30, 2025
@gupnik gupnik requested a review from rkokhatskyi as a code owner June 2, 2025 07:41
satoshiotomakan
satoshiotomakan previously approved these changes Jun 3, 2025
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for the codecov subscription

@gupnik gupnik merged commit 2232874 into master Jun 3, 2025
17 checks passed
@gupnik gupnik deleted the gupnik/rust-memory-leak branch June 3, 2025 13:43
tracyharbutte13 added a commit to tracyharbutte13/wallet-core that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants