Skip to content

Conversation

@gupnik
Copy link
Collaborator

@gupnik gupnik commented May 26, 2025

Description

This PR adds a parameter while importing a key to specify the derivation.

How to test

Added Tests

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@gupnik gupnik requested a review from satoshiotomakan as a code owner May 26, 2025 11:42
@github-actions
Copy link

Binary size comparison

➡️ aarch64-apple-ios: 14.01 MB

➡️ aarch64-apple-ios-sim: 14.01 MB

➡️ aarch64-linux-android: 18.48 MB

➡️ armv7-linux-androideabi: 15.46 MB

➡️ wasm32-unknown-emscripten: 13.16 MB

Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshiotomakan satoshiotomakan merged commit 3b6d7e8 into master May 28, 2025
14 checks passed
@satoshiotomakan satoshiotomakan deleted the gupnik/import-key-custom-derivation branch May 28, 2025 07:23
zkrypt-crossbar pushed a commit to Cramiumlabs/wallet-core that referenced this pull request Jun 15, 2025
zkrypt-crossbar pushed a commit to Cramiumlabs/wallet-core that referenced this pull request Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants