- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.8k
          Support for signing wasm/MsgInstantiateContract transactions
          #4368
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
  
    Support for signing wasm/MsgInstantiateContract transactions
  
  #4368
              Conversation
wasm/MsgInstantiateContract transactions
      | Hi @gupnik, could you please take a look? | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @enriquesouza, thanks for the PR. There's a minor formatting issue. Could you fix that please?
| 
 Sorry. I missed that. Where is it? | 
| Hi @enriquesouza, you can run  | 
| 
 Done. | 
| 
 Thanks @enriquesouza but it still continues to fail: https://github.com/trustwallet/wallet-core/actions/runs/14736373444/job/41403605555?pr=4368 | 
…ouza/wallet-core into wasm_instantiate_contract_fixed
| 
 It should be ok now I've also run  | 
| 
 Thanks @enriquesouza but it seems that we now have a minor clippy warning. Could you please take a look at that as well? https://github.com/trustwallet/wallet-core/actions/runs/14755148818/job/41521615223?pr=4368 | 
| 
 Funny bc I removed that days ago This is what I get:  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…wallet#4368) * my tracked commit * MsgInstantiateContract * revert formatting * test * Tests fixes and broadcast * cargo fmt * remove unused --------- Co-authored-by: gupnik <mail.guptanikhil@gmail.com>
…wallet#4368) * my tracked commit * MsgInstantiateContract * revert formatting * test * Tests fixes and broadcast * cargo fmt * remove unused --------- Co-authored-by: gupnik <mail.guptanikhil@gmail.com>
Summary
This PR adds support for signing CosmWasm
MsgInstantiateContracttransactions on Cosmos SDK–based chains.Changes
cosmwasm.wasm.v1.MsgInstantiateContractwasm_message_instantiate_contract.rssign_wasm_contract.rsNotes
Tests
Previous PR closed
#4355