Skip to content

Conversation

@gupnik
Copy link
Collaborator

@gupnik gupnik commented Apr 3, 2025

Description

Renames Swift Package to WalletCoreSwiftProtobuf

How to test

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@gupnik gupnik requested a review from satoshiotomakan as a code owner April 3, 2025 09:48
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

Binary size comparison

➡️ aarch64-apple-ios: 13.93 MB

➡️ aarch64-apple-ios-sim: 13.93 MB

➡️ aarch64-linux-android: 18.35 MB

➡️ armv7-linux-androideabi: 15.37 MB

➡️ wasm32-unknown-emscripten: 13.06 MB

@gupnik gupnik marked this pull request as draft April 8, 2025 05:12
@gupnik gupnik mentioned this pull request Apr 10, 2025
5 tasks
@gupnik gupnik marked this pull request as ready for review April 10, 2025 12:28
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshiotomakan satoshiotomakan merged commit 4eaaa60 into master Apr 11, 2025
14 checks passed
@satoshiotomakan satoshiotomakan deleted the gupnik/swift-protobuf-rename branch April 11, 2025 10:23
enriquesouza pushed a commit to enriquesouza/wallet-core that referenced this pull request Apr 18, 2025
* Renames Swift Package to WalletCoreSwiftProtobuf

* Fixes build

* Use SwiftProtobuf in podspec

* Updates playground

* Trigger Build

* Updates podspec

* Use WalletCoreSwiftProtobuf Podspec

* Updates Podspec

* Fixes deprecated API usage

---------

Co-authored-by: Sergei Boiko <127754187+satoshiotomakan@users.noreply.github.com>
zkrypt-crossbar pushed a commit to Cramiumlabs/wallet-core that referenced this pull request Jun 15, 2025
* Renames Swift Package to WalletCoreSwiftProtobuf

* Fixes build

* Use SwiftProtobuf in podspec

* Updates playground

* Trigger Build

* Updates podspec

* Use WalletCoreSwiftProtobuf Podspec

* Updates Podspec

* Fixes deprecated API usage

---------

Co-authored-by: Sergei Boiko <127754187+satoshiotomakan@users.noreply.github.com>
zkrypt-crossbar pushed a commit to Cramiumlabs/wallet-core that referenced this pull request Jun 21, 2025
* Renames Swift Package to WalletCoreSwiftProtobuf

* Fixes build

* Use SwiftProtobuf in podspec

* Updates playground

* Trigger Build

* Updates podspec

* Use WalletCoreSwiftProtobuf Podspec

* Updates Podspec

* Fixes deprecated API usage

---------

Co-authored-by: Sergei Boiko <127754187+satoshiotomakan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants