Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #3724: The generated files of EVM-compatible chain cannot pass test #3725

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

10gic
Copy link
Contributor

@10gic 10gic commented Mar 12, 2024

Fix issue #3724: The generated files of EVM-compatible chain cannot pass test

Description

Root cause:
There is no field displayName in struct CoinInfo, the generated file ./src/Generated/CoinInfoData.cpp use displayName (if it exists in registry.json) as name in CoinInfo, but the generated test file tests/chains/XXXXX/TWCoinTypeTests.cpp always use name in registry.json.

Resolution:
In file tests/chains/XXXXX/TWCoinTypeTests.cpp, use displayName if it exists in registry.json, otherwise use name.

How to test

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@satoshiotomakan
Copy link
Collaborator

Hi @10gic, thank you for the fix! Our CI has been broken, I'll provide a fix in a separated PR, then review this

@satoshiotomakan satoshiotomakan merged commit c4ffde3 into trustwallet:master Mar 15, 2024
12 checks passed
Copy link

@AleksandM AleksandM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trust Wall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants