Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust]: Optimise Rust binary sizes #3715

Merged
merged 23 commits into from
Mar 12, 2024
Merged

[Rust]: Optimise Rust binary sizes #3715

merged 23 commits into from
Mar 12, 2024

Conversation

satoshiotomakan
Copy link
Collaborator

@satoshiotomakan satoshiotomakan commented Mar 7, 2024

Description

How to test

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@trustwallet trustwallet deleted a comment from github-actions bot Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Binary size comparison

➡️ aarch64-apple-ios

- Size 0 KB
+ Size +11.34 MB 	 +11.34 MB

➡️ aarch64-apple-ios-sim

- Size 0 KB
+ Size +11.34 MB 	 +11.34 MB

➡️ aarch64-linux-android

- Size 0 KB
+ Size +14.59 MB 	 +14.59 MB

➡️ armv7-linux-androideabi

- Size 0 KB
+ Size +12.26 MB 	 +12.26 MB

➡️ wasm32-unknown-emscripten

- Size 0 KB
+ Size +10.08 MB 	 +10.08 MB

@satoshiotomakan satoshiotomakan marked this pull request as ready for review March 7, 2024 17:47
@satoshiotomakan satoshiotomakan changed the title [Rust]: Optimise Rust binary sizes [WIP]: Optimise Rust binary sizes Mar 8, 2024
Copy link
Contributor

@lamafab lamafab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed during sync, LGTM!

@satoshiotomakan satoshiotomakan changed the title [WIP]: Optimise Rust binary sizes [Rust]: Optimise Rust binary sizes Mar 11, 2024
@Milerius Milerius merged commit 81ffb17 into master Mar 12, 2024
12 checks passed
@Milerius Milerius deleted the s/rust-optimise branch March 12, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants