-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC/Bitcoin/Utxo] Correctly Consider Fees for UTXO Selection #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamafab
changed the title
[PoC/Bitcoin/Utxo] Correclty Consider Fees for UTXO selectionelection
[PoC/Bitcoin/Utxo] Correclty Consider Fees for UTXO Selection
Jan 17, 2024
lamafab
changed the title
[PoC/Bitcoin/Utxo] Correclty Consider Fees for UTXO Selection
[PoC/Bitcoin/Utxo] Correctly Consider Fees for UTXO Selection
Jan 17, 2024
satoshiotomakan
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The estimation algorithm looks promising and quite clear to understand!
I have only one major change request, please consider it t be changed or discussed
…calculating sighash
Milerius
approved these changes
Jan 22, 2024
satoshiotomakan
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3666 for more context.
Update
So, I know made the following changes:
tw_utxo
now considers fees in UTXO selection.tw_utxo
when calling it indirectly viaBitcoinEntry.sign
.InputSelector::SelectAscending
is used by default.Simplify the transaction builder;Brc20Plan
now returns the signed outputs directly (@JaimeToca ).input_selection.rs
which checks the input selection and fee calculation accordingly.tw_utxo
, I need to adjust/inspect those later (covered ininput_selection.rs
).fee_estimate.rs
, covered ininput_selection.rs
BitcoinPlanBuilder
(for now).Overall this is good to go,
but I'd like to take some extra time for the polishing. @JaimeToca could already make use of this, so I can push the polishing in another PR.