[Rust/BNB]: Move BNB Beacon chain to Rust #3589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Amino encoding
* TODO Add tests, handle all message types
* Remove C++ Signing tests
Milerius
approved these changes
Dec 13, 2023
lamafab
reviewed
Dec 13, 2023
lamafab
approved these changes
Dec 13, 2023
|
Unfortunately, yes
|
zkrypt-crossbar
pushed a commit
to Cramiumlabs/wallet-core
that referenced
this pull request
Jun 15, 2025
* [BNB]: Generate BNB Beacon chain skeleton files in Rust * [BNB]: Implement `BinanceAddress`, add Address tests * [BNB]: Add TBinance address tests * [BNB]: Add Transaction and its encoding, prehashing * Add Amino encoding * [BNB]: Sign a transaction * TODO Add tests, handle all message types * [BNB]: Add a signing test * [BNB]: Add `SendOrder`, `CancelOrder` * [BNB]: Add Token orders * [BNB]: Add `TokenBurnOrder`, `HTLTOrder` * [BNB]: Add `DepositHTLT` * [BNB]: Add `ClaimHTLTOrder`, `RefundHTLTOrder` * [BNB]: Add `TransferOutOrder` * [BNB]: Add `SideChainDelegate`, `SideChainRedelegate`, `SideChainUndelegate` orders * [BNB]: Add `TimeLock`, `TimeRelock`, `TimeUnlock` orders * [BNB]: Implement Transaction Compiler * [BNB]: Increase code coverage * [BNB]: Replace C++ implementation * [BNB]: Move TX preimage implementation to `JsonPreimager` * Remove C++ Signing tests * [BNB]: Extend `CoinEntry` documentation * [CI] Trigger CI * [BNB]: Remove `TransactionCompilerBuildInput` * [BNB]: Avoid duplicating code * [BNB]: Add fuzz tests
zkrypt-crossbar
pushed a commit
to Cramiumlabs/wallet-core
that referenced
this pull request
Jun 21, 2025
* [BNB]: Generate BNB Beacon chain skeleton files in Rust * [BNB]: Implement `BinanceAddress`, add Address tests * [BNB]: Add TBinance address tests * [BNB]: Add Transaction and its encoding, prehashing * Add Amino encoding * [BNB]: Sign a transaction * TODO Add tests, handle all message types * [BNB]: Add a signing test * [BNB]: Add `SendOrder`, `CancelOrder` * [BNB]: Add Token orders * [BNB]: Add `TokenBurnOrder`, `HTLTOrder` * [BNB]: Add `DepositHTLT` * [BNB]: Add `ClaimHTLTOrder`, `RefundHTLTOrder` * [BNB]: Add `TransferOutOrder` * [BNB]: Add `SideChainDelegate`, `SideChainRedelegate`, `SideChainUndelegate` orders * [BNB]: Add `TimeLock`, `TimeRelock`, `TimeUnlock` orders * [BNB]: Implement Transaction Compiler * [BNB]: Increase code coverage * [BNB]: Replace C++ implementation * [BNB]: Move TX preimage implementation to `JsonPreimager` * Remove C++ Signing tests * [BNB]: Extend `CoinEntry` documentation * [CI] Trigger CI * [BNB]: Remove `TransactionCompilerBuildInput` * [BNB]: Avoid duplicating code * [BNB]: Add fuzz tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move BNB Beacon chain to Rust.
How to test
Run Rust, C++, Android and iOS tests
Breaking Changes
TWTransactionCompilerBuildInputFFI.TODO
Checklist
If you're adding a new blockchain