Support Bech32M, Segwit v1, BIP350 #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1345 +/- ##
==========================================
- Coverage 95.41% 95.40% -0.01%
==========================================
Files 443 443
Lines 13401 13376 -25
==========================================
- Hits 12786 12762 -24
+ Misses 615 614 -1
Continue to review full report at Codecov.
|
hewigovens
reviewed
Mar 31, 2021
hewigovens
approved these changes
Apr 1, 2021
vikmeup
approved these changes
Apr 26, 2021
SHH-HaoZhang
pushed a commit
to monacohq/wallet-core
that referenced
this pull request
Oct 15, 2021
* Support Bech32M, Segwit v1, BIP350 * Review findings Co-authored-by: Catenocrypt <catenocrypt@users.noreply.github.com>
cornbread78
pushed a commit
to cornbread78/wallet-core
that referenced
this pull request
Dec 22, 2021
* Support Bech32M, Segwit v1, BIP350 * Review findings Co-authored-by: Catenocrypt <catenocrypt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support BIP350, New Bech32M checksum for segwit addresses with version >= 1. Fixes #1331 .
Testing instructions
Unit tests (Bech32, Segwit)
Types of changes
Checklist
[WIP]if necessary.