This repository was archived by the owner on May 28, 2019. It is now read-only.
Add Bitcoin Test Net and fix some bugs#79
Open
zhaojiewen wants to merge 15 commits intotrustwallet:masterfrom
Open
Add Bitcoin Test Net and fix some bugs#79zhaojiewen wants to merge 15 commits intotrustwallet:masterfrom
zhaojiewen wants to merge 15 commits intotrustwallet:masterfrom
Conversation
alejandro-isaza
suggested changes
Nov 6, 2018
hewigovens
suggested changes
Nov 7, 2018
alejandro-isaza
approved these changes
Nov 7, 2018
Contributor
|
@zhaojiewen Thanks for contributing, could you please check the ci status? some testcases failed |
Author
@hewigovens I have fix it, thanks! |
hewigovens
reviewed
Nov 9, 2018
| }; | ||
| if (hrp) { | ||
| *hrp = [NSString stringWithUTF8String:hrpBuf]; | ||
| NSArray<NSString*>* bitcoinsHRP = @[@"bc",@"tb"]; |
Contributor
There was a problem hiding this comment.
This part is tricky, since this is the general decoding method, what if "ltc" for Litecoin? It's better to move this validation to BitcoinSegwitAddress or somewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.