Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blockchain field to the coin type #77

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Add Blockchain field to the coin type #77

merged 4 commits into from
Jul 12, 2022

Conversation

covain
Copy link
Collaborator

@covain covain commented Jul 12, 2022

An idea how to improve, simplify code and reduce potential errors

@covain covain added the enhancement New feature or request label Jul 12, 2022
@covain covain requested a review from hewigovens July 12, 2022 16:33
@covain covain self-assigned this Jul 12, 2022
@hewigovens
Copy link
Contributor

Let's do blockchain enum type, not just isEvm (bool)

@hewigovens hewigovens changed the title Add IsEvm field to the coin type Add Blockchain field to the coin type Jul 12, 2022
Copy link
Contributor

@hewigovens hewigovens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@covain covain merged commit 40a1ef6 into master Jul 12, 2022
@covain covain deleted the covain/evm-coins branch July 12, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants