opendkim/opendkim.c: add two missing dkimf_dstring_get() calls #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the build with CFLAGS="-Werror=incompatible-pointer-types", which some newer compilers are planning to make default. Gentoo-Bug: https://bugs.gentoo.org/919366
futatuki
reviewed
Apr 22, 2024
opendkim/opendkim.c
Outdated
| @@ -11656,8 +11656,8 @@ mlfi_eoh(SMFICTX *ctx) | |||
| (status != 0 || user == NULL || domain == NULL || | |||
| user[0] == '\0' || domain[0] == '\0')) | |||
| { | |||
| strlcpy(addr, conf->conf_defsender, sizeof addr); | |||
| status = dkim_mail_parse(addr, &user, &domain); | |||
| strlcpy(dkimf_dstring_get(addr), conf->conf_defsender, sizeof addr); | |||
There was a problem hiding this comment.
It seems it should use dkim_dstring_copy() instead of strlcpy().
There was a problem hiding this comment.
Probably, I changed it in an additional commit. Thanks.
There was a problem hiding this comment.
I confirmed the commit, and it looks good for me. I'm sorry for the typo on function name, and thank you for the commit.
I'll merge this to my branch.
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
…e-pointer-types Fix wrong usage of dkimf_string *addr in mlfi_eoh().
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build with CFLAGS="-Werror=incompatible-pointer-types", which some newer compilers are planning to make default.
Gentoo-Bug: https://bugs.gentoo.org/919366