-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to OpenSSL 3 #162
base: develop
Are you sure you want to change the base?
Upgrade to OpenSSL 3 #162
Conversation
I notice new include files. What happens if this is built on a system that doesn't yet support openssl 3? |
The new include files already existed in OpenSSL < 3, but there needs to be the appropriate feature detection in |
See also #135. |
|
Rebased, and added a tiny commit which restores compatibility with OpenSSL version 1.1.1. The pull request as now proposed simply moves to the non-deprecated APIs in OpenSSL 3, but all APIs were already present in OpenSSL 1.1.1. |
I'm likely to merge this, but which openSSL 3 system did you test it on? |
@thegushi I used Ubuntu 22.04 LTS with the packaged OpenSSL 3.0.2. It’s good that for once a pull request is not received with total radio |
I'm using this patchset (with openssl-3.1.0). RSA and ED25519 signing as well as validation work as expected. |
Upgrade to OpenSSL 3
Upgrade to OpenSSL 3
The proposed change upgrades OpenSSL to version 3.
The change is not too big, it looks sensible to me, it is backwards compatible, and the test suite passes. I have done successful manual testing using
opendkim-testmsg
for both signing and verifying, using signature algorithmsrsa-sha256
anded25519-sha256
.configure.ac
hasn’t been updated yet. Feedback welcome.