Skip to content

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Dec 22, 2020

Summary

Cleanup tasks uncovered as part of #488.

  • Remove mobile stories (those were a workaround before we had the storybook viewport installed)
  • remove deprecated props in our storybook examples (use size enum instead)
  • addParameters is deprecated

This will cause a Happo change since we remove 3 stories.

How To Test

  • Tests run without errors
  • No other Happo changes besides the removed stories.

@haworku haworku added the type: documentation Improvements or additions to documentation label Dec 22, 2020
@trussworks-infra-zz
Copy link

trussworks-infra-zz commented Dec 22, 2020

Warnings
⚠️ This PR does not include changes to tests, even though it affects source code.

Generated by 🚫 dangerJS against 2ccd10a

@haworku haworku self-assigned this Dec 22, 2020
Copy link
Contributor

@ahobson ahobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haworku haworku merged commit 4b0f7aa into main Jan 6, 2021
@haworku haworku deleted the hw-storybook-cleanup branch January 6, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants