Refactor CommandView::to_owned #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch replaces Vec::from_slice with Vec::extend_from_slice in CommandView::to_owned. This reduces the stack usage on lpc55 to one third (!), from ca. 23 kB to ca. 8 kB with S = 7609.
|
I see similar result in for the NRF target. |
|
Interesting, thanks for checking. I’ll try to take a look at the IR to investigate the differences between the two versions and to produce a minimal example demonstrating the problem so that we can report it. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces Vec::from_slice with Vec::extend_from_slice in CommandView::to_owned. This reduces the stack usage on lpc55 to one third (!), from ca. 23 kB to ca. 8 kB with S = 7609.