Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smaller keyhandle length #8

Closed
wants to merge 1 commit into from
Closed

Smaller keyhandle length #8

wants to merge 1 commit into from

Commits on Feb 1, 2022

  1. Make the Credential ID shorter to work with some services 

    Some services do not accept arbitrary long key handle (aka Credential
ID), which makes the FIDO operations failing. This patch removes some
fields from credential data serialization while making credential ID,
and with this it reduces key handle size by around 30% (from ~320 to ~220
using test site [1]). Tested on Gitlab, and this patch makes it working
correctly (both registering and signing, as opposed to 500 error code
returned otherwise). Presumably the hidden limit is 255 bytes, which
would be compatible with CTAP1.

Resident Keys stay the same, with full metadata stored on the device.

[1] webauthn.bin.coffee
    @szszszsz
    szszszsz committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    ade608c View commit details
    Browse the repository at this point in the history