Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_info: Introduce get-info-full feature and update for CTAP 2.1 #48

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

robin-nitrokey
Copy link
Member

This PR introduces a get-info-full feature for uncommon fields and options in the get_info response, where uncommon means currently not used by fido-authenticator. This means that we do not generate unused serialization code. (As these structs are non-exhaustive, we can move fields out of the feature flag at any time in the future if we start using it in fido-authenticator.)

The PR also adds more fields and options that were introduced in CTAP 2.1.

Fixes: #47

@robin-nitrokey robin-nitrokey requested a review from a team June 21, 2024 08:12
@robin-nitrokey robin-nitrokey merged commit cd854a8 into main Jun 21, 2024
8 checks passed
@robin-nitrokey robin-nitrokey deleted the features branch June 21, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ctap2::get_info: Put unused options behind feature flag
2 participants