use the latest wasm-opt by default #967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I feel that this makes the behavior pretty unpredictable. It also might add all kinds of issues with GitHub rate limiting. However, maybe we can turn this around into explicitly opting-in to this behavior by allow the user to use |
|
makes sense. I'll make the change later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trunk --releaseseems to often fail because of wasm-opt failures (#904)Always using the latest wasm-opt (while allowing the user to override a specific version) seems a good idea.
In particular, when I tried with rustc 1.87.0-nightly and wasm-opt version 122 or 123, the
data-wasm-opt-params="--enable-bulk-memory"workaround in #904 seems unnecessary.