Update definition for trunk-toolbox to include latest support for neveredit rule #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EliSchleifer
commented
Aug 30, 2024
EliSchleifer
commented
- trunk toolbox definition and support changes with version 0.4.1. toolbox can now run correctly with hold-the-line standard upstream support. Also adds support for a new rule "neveredit" which protect files from editing once checked in.
- backwards support for old version of toolbox is maintained.
⏱️ 2h 25m total CI duration on this PR
|
TylerJang27
approved these changes
Sep 3, 2024
linters/trunk-toolbox/plugin.yaml
Outdated
| lint: | ||
| definitions: | ||
| - name: trunk-toolbox | ||
| description: repository level linting tools |
There was a problem hiding this comment.
Suggested change
| description: repository level linting tools | |
| description: Repository-level linting tools |
|
You'll need to also run PLUGINS_TEST_UPDATE_SNAPSHOTS=true npm test linters/trunk-toolbox
git add linters/trunk-toolbox
git commit -m 'add new snapshot'
git push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.