Add remaining pre-commit-hooks #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat-trunk-io
force-pushed
the
pat/precommithooks
branch
from
c0dac9c
to
25f9bca
Compare
det
approved these changes
Jan 22, 2024
|
Looks like you need to define the xml file type. |
TylerJang27
reviewed
Jan 22, 2024
| enabled: false | ||
| output: pass_fail | ||
| read_output_from: stdout | ||
| run: check-added-large-files ${target} |
There was a problem hiding this comment.
Can we add python3 to the front of these if appropriate? Shebangs don't work for these executions on Windows.
There was a problem hiding this comment.
False alarm. This was previously WAI, the files are .exe on Windows and inside of Scripts/, so no need for the python3 bit.
.github/workflows/pr.yaml
Outdated
Comment on lines
118
to
123
| linter_tests_linux: | ||
| name: Linter Tests Linux | ||
| runs-on: public-amd64-2xlarge | ||
| needs: detect_changes | ||
| if: | ||
| needs.detect_changes.outputs.linters == 'true' || needs.detect_changes.outputs.all-linters == |
There was a problem hiding this comment.
If we end up keeping this, can we merge it back into the matrix and add a new field to the object for the correct runner name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.