Enable pnpm in tools #308
Merged
Enable pnpm in tools #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
TylerJang27
reviewed
Jun 12, 2023
tools/pnpm/plugin.yaml
Outdated
| url: https://github.com/pnpm/pnpm/releases/download/${version}/pnpm-${os}-${cpu} | ||
| definitions: | ||
| - name: pnpm | ||
| known_good_version: v8.6.1 |
There was a problem hiding this comment.
Can you omit the v here and add it to the download url?
tools/pnpm/pnpm.test.ts
Outdated
|
|
||
| toolTest({ | ||
| toolName: "pnpm", | ||
| toolVersion: "v8.6.1", |
There was a problem hiding this comment.
Also omit the v here?
laurit17
reviewed
Jun 12, 2023
tools/pnpm/plugin.yaml
Outdated
| url: https://github.com/pnpm/pnpm/releases/download/${version}/pnpm-${os}-${cpu} | ||
| definitions: | ||
| - name: pnpm | ||
| known_good_version: v8.6.1 |
There was a problem hiding this comment.
Generally we want to make the known_good_version a semver - so make this 8.6.1 and then have the URL be v${version}
TylerJang27
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.