Skip to content

biome: run from parent to fix silently broken plugin #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dex4er
Copy link
Contributor

@dex4er dex4er commented Jun 19, 2025

It addresses problems:

  • run_from: ${parent}

Now plugin breaks with the error:

      direct_configs:
        - biome.jsonc
      exit_status: exited
      exit_code: 1
      stdout: (none)
      stderr: |
        /Users/dex4er/Sources/freelens/freelens/biome.jsonc configuration ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

          × Found a nested root configuration, but there's already a root configuration.
          
          i The other configuration was found in /private/var/folders/k5/wyp40c2n6kzfqm5_gzry576c0000gn/T/trunk-501/MbkdUy/GW6i9I.
          
          i Use the migration command from the root of the project to update the configuration.
          
          $ biome migrate --write
          

        configuration ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

          × Biome exited because the configuration resulted in errors. Please fix them.

With this setting biome correctly detects errors.

  • files: html

HTML file types are supported by Biome from 2.0 when enabled in configuration.

@dex4er dex4er changed the title biome: run from parent biome: run from parent to fix silently broken plugin Jun 19, 2025
@TylerJang27
Copy link
Collaborator

Hi! Thanks for the PR! Do you have a repro for this issue? I suspect ${root_or_parent_with_any_config} might be a better setting if the issue is not finding the proper biome.jsonc file to run from.

@dex4er
Copy link
Contributor Author

dex4er commented Jun 25, 2025

Yes, it was noticed in this PR: freelensapp/freelens#874 You can get this commit after merge then remove settings from the .trunk.yaml and see the result: biome plugin silently ignores errors after you'll run trunk check --all -v.

If you say ${root_or_parent_with_any_config} is better then I'll switch to this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants