Skip to content

Fix tests #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: debug/bep-test-base
Choose a base branch
from
Open

Fix tests #545

wants to merge 3 commits into from

Conversation

TylerJang27
Copy link
Collaborator

Address an issue with BEP

@trunk-io Trunk.io
Copy link

trunk-io bot commented Apr 14, 2025

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@TylerJang27
Copy link
Collaborator Author

TylerJang27 commented Apr 14, 2025 •
edited
Loading

FYI this is entirely fictitious, intended to mimic real PR changes for test analysis

Based on #496

@trunk-staging-io Trunk-Staging.io
Copy link

trunk-staging-io bot commented Apr 15, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
test::test_command_succeeds_with_bundle_using_bep The assertion `left == right` failed, expecting 3 but got 4. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

@TylerJang27
Revert "code changes"
e803ff3 
This reverts commit 7b0c4e8.
@trunk-io Trunk.io
Copy link

trunk-io bot commented Apr 15, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@gnalh
Copy link
Collaborator

gnalh commented Apr 15, 2025

Curious what this is

@TylerJang27
Copy link
Collaborator Author

@gnalh see comment, this is entirely fictitious just to generate some realistic past test scenarios that I have context on

@gnalh
Copy link
Collaborator

gnalh commented Apr 15, 2025

@gnalh see comment, this is entirely fictitious just to generate some realistic past test scenarios that I have context on

Yeah, I'm curious what those are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnalh gnalh Awaiting requested review from gnalh gnalh is a code owner

@cmillar-trunk cmillar-trunk Awaiting requested review from cmillar-trunk cmillar-trunk is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerJang27 @gnalh