This repository has been archived by the owner on Apr 23, 2019. It is now read-only.
Setups indices on attached instead of constructor #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the call to setupIndices() indirectly invoked by notifyDataSetChanged() in the constructor. Instead, the initial setup of indices get's done in onAttachedToRecyclerView(), when the adapter has been created and initialized probably. This fixes the problem with calling child's getSectionCount() when it depends on non-null fields initialization at construction time, since the parent constructor get's called before the child's. This fixes #3 and #4
truizlop
added a commit
that referenced
this pull request
Oct 6, 2015
Setups indices on attached instead of constructor
|
for these change, it has been updated to new version..? because im still found these bug #3 |
|
I am preparing a new release which will be published within a few days. I'll notify you here when it's done. |
|
@pratamawijaya new version 1.1.0 has been published fixing the issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3 and #4
Also, I removed
super.onChanged();in SectionDataObserver since the parent method is empty.onAttachedToRecyclerView()is the best place for the initialization that I could find, can't assure it is the best one. But I don't see a reason not to use it.Hope it helps!