This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Internal improvement: Make source-fetcher throw on invalid network #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnidan
suggested changes
Nov 24, 2020
|
Actually wait I want to make another change to this too, you'll see it in a moment... |
|
OK, I fixed that, and also I exported the error so I can do a proper error check with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is a breaking change to
@truffle/source-fetcher.I realized that source-fetcher probably ought to throw if you give it an invalid network ID. So now it does. The
isNetworkValidmethod is gone, because it's now unnecessary. Note obviously this required appropriate modifications toexternal.js.