Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Internal improvement: Migrate Travis-based tests to GitHub Actions #3548

Closed
wants to merge 3 commits into from

Conversation

haltman-at
Copy link
Contributor

This is me attempting to migrate our remaining Travis-based tests to GitHub actions.

We'll, uh, see whether it works?

@haltman-at
Copy link
Contributor Author

OK, I'm going to try removing the truffle obtain step, on the basis that it's probably not necessary?

@haltman-at
Copy link
Contributor Author

Hm, so:

  1. The coverage build is failing due to that indexOf problem. I'll put in the hacky workaround for that, I guess, seeing as we don't currently know how to fix that.
  2. Those two failing builds are supposed to be optional, but GitHub is counting the build as failing anyway. I'll, uh, have to figure out how to fix that...? I thought I it was just continue-on-error, but...

@haltman-at
Copy link
Contributor Author

Ugh, the fricking decoder tests, with their stupid npxs! Of course those are ignoring the version of Truffle present here... we really need to do something about those (#3310).

Well, I guess I can make the debugger thing a separate PR...?

@haltman-at
Copy link
Contributor Author

I'm gonna convert this to draft until after next release, I think.

@haltman-at
Copy link
Contributor Author

Ugh, turns out GHA actually doesn't yet have a notion of allowed failures: actions/runner#2347 :-/

I guess I'll just close this PR for now.

@haltman-at haltman-at closed this Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant