Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Ensure artifacts are saved with db info #3524

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

gnidan
Copy link
Contributor

@gnidan gnidan commented Nov 12, 2020

So that @truffle/db resources are referenced in the resulting truffle compile artifacts

Base automatically changed from truffle-db-mvp to develop November 13, 2020 18:48
@gnidan gnidan force-pushed the artifact-db-resources-from-compile branch from d86ed4b to 892d295 Compare November 13, 2020 22:32
@gnidan gnidan changed the base branch from develop to truffle-db-mvp November 13, 2020 22:32
@gnidan gnidan force-pushed the artifact-db-resources-from-compile branch from 892d295 to 627e121 Compare November 22, 2020 23:44
Copy link
Contributor

@fainashalts fainashalts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This totally makes sense! LGTM but failing CI.

@gnidan
Copy link
Contributor Author

gnidan commented Nov 24, 2020

Yep, sorry, I got jumpy with requesting review, thinking this and #3523 were going to pass 🤭

@gnidan gnidan force-pushed the artifact-db-resources-from-compile branch from 627e121 to 88fb88f Compare November 25, 2020 23:17
Copy link
Contributor

@fainashalts fainashalts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gnidan gnidan merged commit 12ca423 into truffle-db-mvp Dec 2, 2020
@gnidan gnidan deleted the artifact-db-resources-from-compile branch December 2, 2020 18:42
gnidan added a commit that referenced this pull request Dec 8, 2020
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Dec 8, 2020
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Dec 8, 2020
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Dec 8, 2020
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Dec 9, 2020
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Dec 15, 2020
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Dec 17, 2020
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Dec 18, 2020
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Dec 23, 2020
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Dec 23, 2020
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Jan 5, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Jan 7, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Jan 10, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Jan 10, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Jan 11, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Jan 11, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Jan 11, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Jan 12, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Jan 24, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Jan 26, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Jan 27, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Jan 27, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Jan 30, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Feb 1, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Feb 4, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Feb 5, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Feb 9, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Feb 21, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Feb 22, 2021
…-compile

Ensure artifacts are saved with db info
gnidan added a commit that referenced this pull request Feb 24, 2021
…-compile

Ensure artifacts are saved with db info
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants