Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Set maxBuffer to avoid ENOBUFS error message #3138

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

chmanie
Copy link
Contributor

@chmanie chmanie commented Jul 1, 2020

From version 12 on, node doesn't set a very high limit for execSync's maxBuffer anymore. So we have to define that limit ourselves to avoid running into an ENOBUFS error for large contract suites.

See nodejs/node#23027 and 180359b

To see that error message in a real-world project see https://app.circleci.com/pipelines/github/JoinColony/colonyNetwork/2377/workflows/eca45a24-a95a-4bad-8370-153e673cbb75/jobs/12639

Copy link
Contributor

@CruzMolina CruzMolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeeet, thanks @chmanie !

Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, too! Thanks for this!

@gnidan gnidan merged commit 149ada9 into trufflesuite:develop Jul 1, 2020
@CruzMolina CruzMolina mentioned this pull request Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants