set default host to 0.0.0.0 for docker instances

trufflesuite · Aug 2, 2018 · 360af41 · 360af41
1 parent 8bcdf08
commit 360af41
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -8,6 +8,8 @@ RUN npm install
 ADD . .
 RUN npm run build
 
+ENV DOCKER true
+
 EXPOSE 8545
 
 ENTRYPOINT ["node", "./build/cli.node.js"]
diff --git a/args.js b/args.js
@@ -1,4 +1,4 @@
-module.exports = exports = function(yargs, version) {
+module.exports = exports = function(yargs, version, isDocker) {
   return yargs
     .option('p', {
       group: 'Network:',
@@ -11,7 +11,7 @@ module.exports = exports = function(yargs, version) {
       group: 'Network:',
       alias: ['host', 'hostname'],
       type: 'string',
-      default: '127.0.0.1',
+      default: isDocker ? '0.0.0.0' : '127.0.0.1',
       describe: 'Hostname to listen on'
     })
     .option('a', {

diff --git a/cli.js b/cli.js
@@ -17,7 +17,8 @@ var BN = require("bn.js");
 
 var detailedVersion = "Ganache CLI v" + pkg.version + " (ganache-core: " + corepkg.version + ")";
 
-var argv = initArgs(yargs, detailedVersion).argv;
+var isDocker = "DOCKER" in process.env && process.env.DOCKER.toLowerCase() === "true";
+var argv = initArgs(yargs, detailedVersion, isDocker).argv;
 
 function parseAccounts(accounts) {
   function splitAccount(account) {