Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed autoklose verification endpoint #3447

Merged

Conversation

sahil9001
Copy link
Contributor

@sahil9001 sahil9001 commented Oct 17, 2024

Description:

Fixes #3446
Screenshot 2024-10-17 at 2 20 23 PM

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@sahil9001
Copy link
Contributor Author

@rgmz @zricethezav

Copy link
Contributor

@kashifkhan0771 kashifkhan0771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Feedback! Rest looks ok to me.

pkg/detectors/autoklose/autoklose.go Outdated Show resolved Hide resolved
pkg/detectors/autoklose/autoklose.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kashifkhan0771 kashifkhan0771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @sahil9001 - Changes LGTM!

@sahil9001
Copy link
Contributor Author

This counts eligible for Hacktoberfest, right? Can you add label is possible?

@sahil9001
Copy link
Contributor Author

@kashifkhan0771 Thanks for this, can you please review other PRs as well, and add the label, actually I don't know if I am doing this right or not. Your overview will give me an assurance if I am on the right path (eligibility)

@zricethezav
Copy link
Collaborator

Nice work @sahil9001. Thanks for the review @kashifkhan0771. Merging

@zricethezav zricethezav merged commit f7252c5 into trufflesecurity:main Oct 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Issue with correct verification endpoint for autoklose
3 participants