Ignore https: as false positive for slackwebhook detector
#3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan0771
changed the title
https: as false postive for slackwebhook detectorhttps: as false positive for slackwebhook detector
dustin-decker
approved these changes
Oct 16, 2024
|
Thanks for this! |
rgmz
reviewed
Oct 16, 2024
Comment on lines
+126
to
+127
| // back to the default false positive checks | ||
| return detectors.IsKnownFalsePositive(string(result.Raw), detectors.DefaultFalsePositives, true) |
There was a problem hiding this comment.
When would this trigger? Won't the result always contain https:?
Personally, I think https: should be removed from the wordlist.
There was a problem hiding this comment.
Hmm, that can be done as well. For now it was for only one detector so I went with this approach.
There was a problem hiding this comment.
Sorry, the second sentence is a bit of a tangent.
I don't think the second part of the function will ever be reached.
There was a problem hiding this comment.
You’re absolutely right. I’ll simplify the function in next enhancement and remove the second part as it's unnecessary in this case. Appreciate the catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR resolves the issue where unverified Slack webhook secrets were incorrectly ignored due to the presence of
https:being flagged as a false positive. The updated logic ensures that https: is no longer considered a false positive, allowing Slack webhook secrets to be properly detected and processed.Output of unverified slackwebhook:
Ticket:
OSS-36
Checklist:
make test-community)?make lintthis requires golangci-lint)?