[analyze] Add Analyzer for Mailgun #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abmussani
force-pushed
the
impl-data-model-mailgun
branch
from
4ee295b
to
456ff09
Compare
abmussani
changed the title
mcastorina
approved these changes
Aug 13, 2024
abmussani
force-pushed
the
impl-data-model-mailgun
branch
from
4add4e5
to
f3a3285
Compare
mcastorina
reviewed
Sep 5, 2024
Comment on lines
51
to
58
| apiResource := analyzers.Resource{ | ||
| Name: "Mailgun API Key", | ||
| FullyQualifiedName: "Mailgun API Key", | ||
| Type: "api key", | ||
| Metadata: map[string]any{ | ||
| "domains_count": info.TotalCount, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Do you think we need to differentiate this resource somehow? Or is it okay for all keys (across all accounts) to have access to this Mailgun API Key resource?
Since we're adding the domains_count here it seems like it's specific to this key.
corrected variable name for test in detector bucket
abmussani
force-pushed
the
impl-data-model-mailgun
branch
from
f78f2fc
to
e3365b8
Compare
mcastorina
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implemented Analyzer interface for Mailgun.
Checklist:
make test-community)?make lintthis requires golangci-lint)?