Fix race in EscapedUnicode decoder
#3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
dustin-decker
approved these changes
Aug 14, 2024
rgmz
force-pushed
the
fix/decoder-race
branch
from
e648079
to
4a72746
Compare
rgmz
force-pushed
the
fix/decoder-race
branch
from
4a72746
to
6b7104f
Compare
dustin-decker
approved these changes
Sep 26, 2024
kashifkhan0771
pushed a commit
to kashifkhan0771/trufflehog
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes one of the races mentioned in #3027.
There may be a better solution to this specific issue. My interpretation, validated by testing, is that
sources.Chunkis being mutated and read in multiple places and needs to be cloned.Checklist:
make test-community)?make lintthis requires golangci-lint)?