Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add false positive info to protobuf #2729

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Add false positive info to protobuf #2729

merged 1 commit into from
Apr 23, 2024

Conversation

rosecodym
Copy link
Collaborator

@rosecodym rosecodym commented Apr 22, 2024

Description:

This PR adds false positive information to the Result protobuf message in anticipation of us tracking it as first-class secret metadata. We're not doing that yet (it's blocked behind #2643) but setting up the messages now means we'll be able to do it later with less of a code delta.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rosecodym rosecodym requested a review from a team as a code owner April 22, 2024 21:13
FalsePositiveInfo false_positive_info = 11;
}

message FalsePositiveInfo {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Do you foresee a situation where multiple fields in this message will be set to true? I'm wondering if an enum would also do the trick.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentially! i can also foresee us adding additional information to it down the road (e.g. what word from the list was actually matched). i think an enum would also work but it feels more constraining.

@rosecodym rosecodym merged commit af095c2 into main Apr 23, 2024
12 checks passed
@rosecodym rosecodym deleted the protobuf-fp-info branch April 23, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants