Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detector-Competition-Fix: Fix/Deprecate Prospect.io #2081

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

lc
Copy link
Contributor

@lc lc commented Nov 1, 2023

Description:

https://api.prospect.io no longer exists and has been shutdown. This PR removes the detector, updates the protobufs, and removes it from defaults.go

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@lc lc requested a review from a team as a code owner November 1, 2023 00:07
@zricethezav zricethezav added the Hacktoberfest-Detector-Competition-Fix Apply this label if you are fixing a detector for the detector competition label Nov 1, 2023
Copy link
Collaborator

@zricethezav zricethezav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lc lgtm, just needs a conflict resolve

@lc
Copy link
Contributor Author

lc commented Nov 2, 2023

Fixed @zricethezav

@lc
Copy link
Contributor Author

lc commented Nov 2, 2023

aaaand updated protos again

@zricethezav
Copy link
Collaborator

aaaand updated protos again

😬 thanks

@zricethezav zricethezav merged commit 9e52e3e into trufflesecurity:main Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest-Detector-Competition-Fix Apply this label if you are fixing a detector for the detector competition
Development

Successfully merging this pull request may close these issues.

2 participants