Competition-detector-fix: fixed helpscout detector regex and verifier #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zricethezav
added
the
Hacktoberfest-Detector-Competition-Fix
zricethezav
approved these changes
Nov 2, 2023
|
confirmed token change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I created a helpscout account and regenerated token many times and it always gave a [a-z0-9]{40} char long token and not the [A-Za-z0-9]{56} one so i replaced the regex. Maybe that was old format and not valid anymore. i have no way to check if the old format style tokens are supported or not. if they are, we can have a OR style regex match or i can close this PR and create a V2 style detector for the helpscout.
Verifier:
https://developer.helpscout.com/docs-api/
It suggests a basic auth-style API call so added that logic as well
Checklist:
make test-community)?make lintthis requires golangci-lint)?