-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TruffleHog version input for GitHub action #1064
Conversation
This broke anyone currently using the action.
|
@@ -22,7 +26,7 @@ branding: | |||
color: "green" | |||
runs: | |||
using: "docker" | |||
image: "docker://ghcr.io/trufflesecurity/trufflehog:latest" | |||
image: "docker://ghcr.io/trufflesecurity/trufflehog:${{ inputs.version }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really think that the image
field accepts the Github's expression syntax. It pretty much broke the workflow that I'm using. (Like what @james-callahan stated earlier)
One alternative is to give a default value not as seen on line 9, but to set it on this current line. In which I don't really know how to do that from the expression documentation. So like in Javascript, you'd do:
${{ input.version || 'latest' }}
But I guess that would be impossible because the expression syntax treats ||
as an OR
operator.
any idea when can we fix this? |
Fixes this issue trufflesecurity#1064 (comment)
This reverts commit 8dedd08.
Sorry about that everyone, the change has been reverted now. |
Sourced from trufflesecurity/trufflehog's releases. v3.27.0 What's Changed Bump golang.org/x/oauth2 from 0.3.0 to 0.4.0 by @dependabot in trufflesecurity/trufflehog#1039 add bodyclose linter to help prevent file handle leaks by @dustin-decker in trufflesecurity/trufflehog#1048 braintree detector: use production API URL instead of the test sandbo… by @swdbo in trufflesecurity/trufflehog#1054 Update float detector with correct User-Agent and regex by @ahrav in trufflesecurity/trufflehog#1061 update webex detector regex by @ahrav in trufflesecurity/trufflehog#1062 Handle errors in a thread safe manner by @ahrav in trufflesecurity/trufflehog#1052 Add TruffleHog version input for GitHub action by @mcastorina in trufflesecurity/trufflehog#1064 Revert "Add TruffleHog version input for GitHub action (#1064)" by @mcastorina in trufflesecurity/trufflehog#1068 Pull gitparse config options out of pkg consts by @bill-rich in trufflesecurity/trufflehog#1072 Add include exclude spaces for confluence source. by @ahrav in trufflesecurity/trufflehog#1073 Add max commit size by @bill-rich in trufflesecurity/trufflehog#1079 Make archive handler configurable by @bill-rich in trufflesecurity/trufflehog#1077 [chore] - Add tests for errors by @ahrav in trufflesecurity/trufflehog#1071 Skip repo and continue scanning when encountering an error by @mcastorina in trufflesecurity/trufflehog#1080 [chore] - Dont pre-allocate errors slice by @ahrav in trufflesecurity/trufflehog#1083 Add Type() to detector interface by @trufflesteeeve in trufflesecurity/trufflehog#1088 [chore] Remove logrus from engine package by @mcastorina in trufflesecurity/trufflehog#1085 [chore] Remove logrus from github source by @mcastorina in trufflesecurity/trufflehog#1086 Bump github.com/joho/godotenv from 1.4.0 to 1.5.1 by @dependabot in trufflesecurity/trufflehog#1075 [chore] Remove logrus from circleci, filesystem, gitlab, and s3 sources by @mcastorina in trufflesecurity/trufflehog#1089 [chore] - Remove monolithic config struct by @ahrav in trufflesecurity/trufflehog#1091 Make detectors configurable by @ahrav in trufflesecurity/trufflehog#1084 New Contributors @swdbo made their first contribution in trufflesecurity/trufflehog#1054 Full Changelog: trufflesecurity/trufflehog@v3.26.0...v3.27.0 v3.26.0 What's Changed Add openssh-client to trufflehog container by @mcastorina in trufflesecurity/trufflehog#1045 Bump github.com/rabbitmq/amqp091-go from 1.5.0 to 1.6.0 by @dependabot in trufflesecurity/trufflehog#1036 filesystem support for exclude and include filters (2nd attemp) by @mac2000 in trufflesecurity/trufflehog#1033 Fix the typo "programatic" by @nezakoo in trufflesecurity/trufflehog#1046 Add file to confluence proto. by @ahrav in trufflesecurity/trufflehog#1049 Remove false positive detection for CustomRegex by @mcastorina in trufflesecurity/trufflehog#1050
Closes #1040