NAS-126760 / 13.3 / Replace 'SED Password' with 'SED Key' #9906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
AlexKarpov98
reviewed
Apr 2, 2024
There was a problem hiding this comment.
I was not able to reproduce the issue. 🤔
But if you say that problem can be with just password word, can you show it please?
I am fine with SED Key though.
@undsoft - please have a look at it as well.
undsoft
approved these changes
Apr 2, 2024
|
This PR has been merged and conversations have been locked. |
|
@AlexKarpov98 For reference, when using the 'Password' keyword in the label, the field is forced filled in by the password manager extension. Screen.Recording.2024-04-04.at.1.54.41.PM.mov |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no concrete way to stop password manager extensions like Bitwarden from forcefully filling in a field that has any mention of a "password". Setting autocomplete off or other solutions from scale don't work. On scale this problem doesn't exist because we handle forms completely differently from core (slide-ins instead of full-page forms).