Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-127717 / 13.0 / Add syslog_tls_certificate_authority field #9836

Merged
merged 2 commits into from
Mar 26, 2024
Merged

NAS-127717 / 13.0 / Add syslog_tls_certificate_authority field #9836

merged 2 commits into from
Mar 26, 2024

Conversation

bvasilenko
Copy link
Contributor

@bvasilenko bvasilenko commented Mar 17, 2024 •
edited
Loading

Testing

Connect to 13.0 machine

On the System > Advanced page, in the Syslog block

  1. In the Syslog Transport dropdown choose TLS
  2. Select a certificate
  3. Click Save

Expected result:

  1. There should be a "Certificate Authority" dropdown field
  2. This dropdown field should be filled with selectable options from System > CAs.

bvasilenko and others added 2 commits January 30, 2024 14:03
@bvasilenko
NAS-125844 / 13.0 / Javascript error trying to edit disk in web UI (#…
c9f63a2 
…9461)

* Fix edit disk action when name is path

* Fix remarks

---------

Co-authored-by: Boris Vasilenko <bvasilenko@ixsystems.com>
Add syslog_tls_certificate_authority field
f737bf2
@bvasilenko bvasilenko requested a review from a team as a code owner March 17, 2024 20:51
@bvasilenko bvasilenko requested review from undsoft and removed request for a team March 17, 2024 20:51
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-127717

@bugclerk bugclerk changed the title Add syslog_tls_certificate_authority field NAS-127717 / 13.0 / Add syslog_tls_certificate_authority field Mar 17, 2024
@undsoft undsoft changed the base branch from truenas/13.0-stable to truenas/13.3-stable March 25, 2024 10:56
undsoft
undsoft approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I've changed target branch to 13.3-stable and there is now an extra commit.
Please confirm that this is something that needs to be there - looks like we forgot to backport it.

@bvasilenko
Copy link
Contributor Author

bvasilenko commented Mar 25, 2024 •
edited
Loading

Please confirm that this is something that needs to be there - looks like we forgot to backport it.

@undsoft Yes this additional commit will fix another issue in 13.3-stable branch. We forgot to backport it from 13.0-branch

@bvasilenko bvasilenko requested a review from undsoft March 25, 2024 20:13
@undsoft undsoft merged commit 85dc49d into truenas/13.3-stable Mar 26, 2024
3 checks passed
@undsoft undsoft deleted the NAS-127717-13.0 branch March 26, 2024 10:12
@bugclerk
Copy link
Contributor

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-127717 is targeted to the following versions which have not received their corresponding PRs: 13.3

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@undsoft undsoft Awaiting requested review from undsoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bvasilenko @bugclerk @undsoft