Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-123587 / 24.04 / Refactored tables #8659

Merged
merged 6 commits into from
Aug 28, 2023
Merged

NAS-123587 / 24.04 / Refactored tables #8659

merged 6 commits into from
Aug 28, 2023

Conversation

RehanY147
Copy link
Contributor

No description provided.

@RehanY147 RehanY147 requested a review from a team as a code owner August 23, 2023 12:51
@RehanY147 RehanY147 requested review from dszidi and removed request for a team August 23, 2023 12:51
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title Refactored tables NAS-123587 / 24.04 / Refactored tables Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #8659 (80fd6ef) into master (0d06005) will decrease coverage by 0.61%.
The diff coverage is 1.83%.

❗ Current head 80fd6ef differs from pull request most recent head cf4724e. Consider uploading reports for the commit cf4724e to get more accurate results

@@            Coverage Diff             @@
##           master    #8659      +/-   ##
==========================================
- Coverage   59.67%   59.07%   -0.61%     
==========================================
  Files        1242     1238       -4     
  Lines       47658    47480     -178     
  Branches     5828     5810      -18     
==========================================
- Hits        28441    28049     -392     
- Misses      19217    19431     +214     
Files Changed Coverage Δ
...vice/components/idmap-list/idmap-list.component.ts 0.00% <0.00%> (ø)
...os-keytabs-list/kerberos-keytabs-list.component.ts 0.00% <0.00%> (ø)
.../kerberos-realms/kerberos-realms-list.component.ts 0.00% <0.00%> (ø)
...ages/directory-service/directory-service.module.ts 0.00% <0.00%> (ø)
...ges/directory-service/directory-service.routing.ts 0.00% <0.00%> (ø)
.../directory-service/directory-services.component.ts 0.00% <0.00%> (ø)
...cells/ix-cell-actions/ix-cell-actions.component.ts 80.00% <80.00%> (ø)
src/app/modules/ix-table2/ix-table2.module.ts 100.00% <100.00%> (ø)

... and 42 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@dszidi dszidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. No regressions observed

image

@RehanY147 RehanY147 enabled auto-merge (squash) August 28, 2023 11:55
@RehanY147 RehanY147 merged commit 7d0190b into master Aug 28, 2023
6 checks passed
@RehanY147 RehanY147 deleted the NAS-123587 branch August 28, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants